fix(textarea): placeholder 可以设置为空字符串 #2979
Conversation
Walkthrough本次 PR 修改主要集中在 TextArea 组件的事件处理和样式管理上。修改包括更新事件处理函数类型从 Changes
Sequence Diagram(s)sequenceDiagram
participant U as 用户
participant T as TextArea 组件
participant I as isDisabled 辅助函数
U->>T: 触发 Focus/Blur/Change 事件
T->>I: 检查组件状态 (disabled/readOnly)
I-->>T: 返回状态 (启用/禁用)
alt 状态启用
T->>T: 执行相应事件逻辑 (onFocus/onBlur/onChange)
else 状态禁用
T->>T: 忽略事件处理
end
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
action:review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #2979 +/- ##
=============================================
+ Coverage 85.74% 85.75% +0.01%
=============================================
Files 277 277
Lines 18105 18110 +5
Branches 2745 2735 -10
=============================================
+ Hits 15524 15531 +7
+ Misses 2576 2574 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/packages/textarea/textarea.taro.tsx (1)
86-94: 建议优化事件处理函数事件处理逻辑可以进一步优化，建议使用可选链操作符简化空值检查。
- const text = event?.detail?.value - if (text) { + const text = event?.detail?.value ?? '' + if (text !== '') {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/packages/textarea/__test__/__snapshots__/textarea.spec.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (2)
src/packages/textarea/textarea.taro.tsx(5 hunks)src/packages/textarea/textarea.tsx(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
🔇 Additional comments (8)
src/packages/textarea/textarea.taro.tsx (4)
4-10: 事件类型定义更新将事件类型从
Event更改为BaseEventOrig提高了类型安全性，更好地符合 Taro 框架的类型系统。Also applies to: 30-31
96-101: 代码优化：新增辅助函数通过抽取
isDisabled辅助函数来处理禁用状态的判断，提高了代码的可维护性和可读性。Also applies to: 103-106
111-121: 类名管理优化使用
classNames工具函数重构了类名管理，提高了代码的可读性和可维护性。条件类名的组织更加清晰。Also applies to: 137-139, 155-157
149-151: 占位符处理优化现在可以正确处理空字符串作为占位符，符合需求。使用
undefined判断而不是空值判断，逻辑更加准确。src/packages/textarea/textarea.tsx (4)
86-87: useEffect 优化简化了
useEffect的条件语句，提高了代码的可读性。
106-116: 事件处理一致性Web 版本的禁用状态处理与 Taro 版本保持一致，通过
isDisabled辅助函数统一了处理逻辑。
121-132: 类名管理一致性类名管理方式与 Taro 版本保持一致，使用
classNames工具统一处理条件类名，提高了代码的可维护性。Also applies to: 137-139, 161-163
155-157: 占位符处理一致性占位符的处理逻辑与 Taro 版本保持一致，支持设置空字符串作为占位符。
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit