-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Abstract away data access/cloning/mutation/etc., add in some laziness #10
Open
jdeal
wants to merge
67
commits into
master
Choose a base branch
from
abstract-cloning-and-mutation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched traverse to using helpers. Switched $slice to using wrapping objects. This proves out the concept (and performance which is tricky) of abstracting away the direct cloning and mutation of objects and arrays. This cleans up the code, getting rid of some weird "lookahead" bits and "mutation markers" and paves the way for working with other objects like Maps and Sets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still a lot of cleanup to do here, but the basic pieces are in place now.
The goals here are:
It was really hard to do all this and keep everything as performant (at least for simple cases). So there's lots of funny business going on in
src/utils/data.js
. I even use some macros to inline code in a few places. 😬 Ultimately, I think the extra complexity in one place is worth the reduced complexity and increased flexibility in other places.Still todo:
src/utils/data.js
a little more DRY.unwrap
calls in some cases by marking some navigators as able to accept wrapped data.