Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds newline after h3 for github styling. Fixes #46 #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

viveleroi
Copy link

As noted in the issue, github fails to render view source links correctly when preceded by an html element. The only solution I'm aware of is to force an empty line between them. Luckily, that line is not rendered:

addNode(node)

[Ⓣ][1]

Because the entryMarkdown array joins with \n and \n\n is converted into <br><br>, this solution appends an empty string (which gets converted into an empty newline). It not the nicest code but it anything else would involve potentially breaking changes to the format method.

Since the h3 and line of links are now separate elements, the h3 no longer needed a hard-coded \n. However, I wasn't sure which text you intended the .replace(/ {2,}/g, ' ') to apply to so I guessed.

@evanplaice
Copy link

Can confirm. I ran into the same issue. Without a preceding line the links are broken in the Markdown output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants