feat: Add Group.projects #494
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only suggestion id have would be moving the interface information into the corresponding service, just for consistency. |
|
@jdalrymple Yes, I did not do this because also other endpoints return the same structure, e.g. /api/v4/projects returns projects as well. But I could move it to servcies/Projects.ts and reference it from Groups.ts? |
|
Anyone, can this MR be merged? |
|
Yea sorry! I though i responded 🤦♂️ I would move it into the Projects.js file! |
This commit also introduces a minimal typed response as a first step towards jdalrymple#384.
Granjow
force-pushed
the
feature/granjow/group-projects
branch
from
2c46fd3 to
6eef140
Compare
|
@jdalrymple Updated! I suffixed the interface with |
|
🎉 This PR is included in version 11.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also introduces a minimal typed response as a first step
towards #384.