Update missing type information

jdalrymple · Jul 29, 2023 · c6cca5b · c6cca5b
1 parent f8b7fe0
commit c6cca5b
Showing 1 changed file with 21 additions and 18 deletions.
diff --git a/packages/core/src/resources/ProtectedBranches.ts b/packages/core/src/resources/ProtectedBranches.ts
@@ -10,7 +10,8 @@ import type {
 } from '../infrastructure';
 
 export type ProtectedBranchAccessLevel = 0 | 30 | 40 | 60;
-export interface ExtendedProtectedBranchAccessLevel {
+export interface ExtendedProtectedBranchAccessLevelSchema {
+  id: number;
   access_level: ProtectedBranchAccessLevel;
   access_level_description: string;
   user_id?: number | null;
@@ -20,37 +21,39 @@ export interface ExtendedProtectedBranchAccessLevel {
 export interface ProtectedBranchSchema extends Record<string, unknown> {
   id: number;
   name: string;
-  push_access_levels?: ExtendedProtectedBranchAccessLevel[];
-  merge_access_levels?: ExtendedProtectedBranchAccessLevel[];
-  unprotect_access_levels?: ExtendedProtectedBranchAccessLevel[];
+  push_access_levels?: ExtendedProtectedBranchAccessLevelSchema[];
+  merge_access_levels?: ExtendedProtectedBranchAccessLevelSchema[];
+  unprotect_access_levels?: ExtendedProtectedBranchAccessLevelSchema[];
   allow_force_push: boolean;
   code_owner_approval_required: boolean;
 }
 
+export type ProtectedBranchAllowOptions = OneOf<{
+  user_id: number;
+  group_id: number;
+  access_level: number;
+}>;
+
+export type EditsProtectedBranchAllowOptions = {
+  _destroy?: boolean;
+} & ProtectedBranchAllowOptions;
+
 export type CreateProtectedBranchOptions = {
   allowForcePush?: boolean;
-  allowedToMerge?: Record<string, number>[];
-  allowedToPush?: Record<string, number>[];
-  allowedToUnprotect?: Record<string, number>[];
+  allowedToMerge?: ProtectedBranchAllowOptions[];
+  allowedToPush?: ProtectedBranchAllowOptions[];
+  allowedToUnprotect?: ProtectedBranchAllowOptions[];
   codeOwnerApprovalRequired?: boolean;
   mergeAccessLevel?: ProtectedBranchAccessLevel;
   pushAccessLevel?: ProtectedBranchAccessLevel;
   unprotectAccessLevel?: ProtectedBranchAccessLevel;
 };
 
-export type EditProtectedBranchAllow = {
-  _destroy?: boolean;
-} & OneOf<{
-  user_id: number;
-  group_id: number;
-  access_level: number;
-}>;
-
 export type EditProtectedBranchOptions = {
   allowForcePush?: boolean;
-  allowedToMerge?: EditProtectedBranchAllow[];
-  allowedToPush?: EditProtectedBranchAllow[];
-  allowedToUnprotect?: EditProtectedBranchAllow[];
+  allowedToMerge?: EditsProtectedBranchAllowOptions[];
+  allowedToPush?: EditsProtectedBranchAllowOptions[];
+  allowedToUnprotect?: EditsProtectedBranchAllowOptions[];
   codeOwnerApprovalRequired?: boolean;
 };