Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves wait_exponential_jitter #426

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

yxtay
Copy link
Contributor

@yxtay yxtay commented Dec 18, 2023

Summary

Improves wait_exponential_jitter to inherit wait_exponential
- Reuses wait_exponential.__call__ method instead of of duplicating code
- Follows argument names of wait_exponential
- Adds min argument
- Supports supplying max, jitter, min arguments as timedelta

Tests

pytest tests/test_tenacity.py::TestWaitConditions::test_wait_exponential_jitter

jd
jd previously approved these changes Dec 18, 2023
@mergify mergify bot dismissed jd’s stale review December 18, 2023 08:40

Pull request has been modified.

@yxtay yxtay requested a review from jd December 18, 2023 08:44
@yxtay
Copy link
Contributor Author

yxtay commented Nov 14, 2024

Is there anything blocking this from being merged? Deprecation concerns? It's been almost 1 year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants