Support integer Struct tags #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tagged unions only supported `str` tag values. We now also support `int` tag values, with a few caveats: - A single `Union` of `Struct` types cannot mix both `int` and `str` tag types. - Integer `tag` values currently only support values that fit in an int64 (-2**63 <= tag <= 2**63 - 1). This restriction has also been added to `IntEnum` and integer `Literal` types (previously these supported up to a `uint64`). This restriction makes the implementation easier, but can be removed if needed in the future. For now a `NotImplementedError` is raised if the user attempts to use out-of-range integer values, pointing them to raise an issue on GitHub if they need the feature.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tagged unions only supported
strtag values. We now alsosupport
inttag values, with a few caveats:UnionofStructtypes cannot mix bothintandstrtagtypes.
tagvalues currently only support values that fit in anint64 (
-2**63 <= tag <= 2**63 - 1). This restriction has also been addedto
IntEnumand integerLiteraltypes (previously these supported upto a
uint64). This restriction makes the implementation easier, butcan be removed if needed in the future. For now a
NotImplementedErroris raised if the user attempts to use out-of-range integer values,
pointing them to raise an issue on GitHub if they need the feature.
Fixes #134.