Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Async API client #45

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

New Async API client #45

wants to merge 23 commits into from

Conversation

jbusecke
Copy link
Owner

@jbusecke jbusecke commented May 6, 2024

I have taken what I have learned from #42 and written a completely new logic to get info from the ESGF API.
This one is a bunch simpler, not async, and seems to actually get a lot more URL information (tested with the cases in #42).

I think the design here can also accomodate leap-stc/cmip6-leap-feedstock#147 in general. It might also be relevant to leap-stc/cmip6-leap-feedstock#133 (if we want to inject dataset level tracking ids).

Ill test drive this over at the CMIP6 feedstock and will then finish up over here.

This seems to work really well so far. I had a few hangs, but after actually raising timeouts, and catching them, things seem to work fine.
Will have to finish up the things below, but am already starting to use this on the CMIP recipe.

@jbusecke jbusecke changed the title New API client New Async API client May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant