Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output pin inversion, update docs. #186

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

solnus
Copy link
Contributor

@solnus solnus commented Aug 21, 2024

Some hardware configurations (different transistor types, direct drive) need the output pin value inverted from the current implementation. This patch adds a new option to invert the output value. It also fixes a few documentation issues, and fixes a parsing problem in the gpioreadall.py script (presumably on newer rpi OS versions).

@rondoc
Copy link

rondoc commented Aug 21, 2024 via email

@solnus
Copy link
Contributor Author

solnus commented Aug 21, 2024

@rondoc are your referring to issue #189? This is a different feature.

@rondoc
Copy link

rondoc commented Aug 21, 2024 via email

@solnus solnus force-pushed the main branch 2 times, most recently from 1e1b222 to 4f04569 Compare August 22, 2024 02:59
@solnus
Copy link
Contributor Author

solnus commented Aug 23, 2024

@jbruce12000 do you want me to separate the bug fixes from the new config flag here, to have different commits for them?

@jbruce12000 jbruce12000 merged commit a2b3071 into jbruce12000:main Aug 24, 2024
@jbruce12000
Copy link
Owner

nope... but separate future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants