-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output pin inversion, update docs. #186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is #186 ? How to access this? I am not a software guy.
Ron
…On Wed, Aug 21, 2024, 11:33 AM solnus ***@***.***> wrote:
@rondoc <https://github.com/rondoc> are your referring to issue #189
<#189>? This is a
different feature.
—
Reply to this email directly, view it on GitHub
<#186 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXA65G6ZYFSPANWFNL2XD6LZSTMP5AVCNFSM6AAAAABM3GVBYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBSG4YTOMBQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
solnus
force-pushed
the
main
branch
2 times, most recently
from
August 22, 2024 02:59
1e1b222
to
4f04569
Compare
@jbruce12000 do you want me to separate the bug fixes from the new config flag here, to have different commits for them? |
jbruce12000
approved these changes
Aug 24, 2024
nope... but separate future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hardware configurations (different transistor types, direct drive) need the output pin value inverted from the current implementation. This patch adds a new option to invert the output value. It also fixes a few documentation issues, and fixes a parsing problem in the gpioreadall.py script (presumably on newer rpi OS versions).