Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi key support #238

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Multi key support #238

wants to merge 13 commits into from

Conversation

techanon
Copy link
Contributor

Added methods: _key_type
Updated methods: __construct, get, put, remove, field
TODO methods: __call, next

} else {
$q->data = (array) $res;
$q->keyval = $id;
switch ($this->_key_type()) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think $this should be $q here and on 536.

@techanon
Copy link
Contributor Author

I think both of those comments might be related (first one causing the second). Can you run those tests again with that model fix I pushed?

@jbroadway
Copy link
Owner

Still getting the exact same results. Do you have PHPUnit, and can you try running the tests via phpunit.phar tests/ModelTest.php? I'm also getting an error in the ExtendedModel test too:

$ phpunit.phar tests/ExtendedModelTest.php 
PHPUnit 4.4.0 by Sebastian Bergmann.

Configuration read from /Users/lux/projects/elefant/www/phpunit.xml.dist

FSSSS

Time: 32 ms, Memory: 3.50Mb

There was 1 failure:

1) ExtendedModelTest::test_create
Failed asserting that null matches expected 1.

/Users/lux/projects/elefant/www/tests/ExtendedModelTest.php:52

FAILURES!                                        
Tests: 1, Assertions: 4, Failures: 1, Skipped: 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants