[JBEAP-22930] Mojarra -- test branch used for EAP 7.4 using SE 17 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify version in POM to add support for Java 17 Minor test update to work around minor data change in testing Add GH Action workflow
Add JDK version as part of cache key
|
@bstansberry , @fjuma I would appreciate a quick sanity check if/when one or both of you have a chance. Seems like a safe enough change... |
bstansberry
requested changes
Apr 1, 2024
| </requireJavaVersion> | ||
| </rules> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
If you remove this you need something to enforce the use of SE 8 when releasing. For example:
https://github.com/wildfly/wildfly/blob/main/pom.xml#L1133-L1146
So I think you need to leave the plugin in place but just tweak the execution by moving the configuration into it and setting the phase to 'deploy'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/JBEAP-22930
Modify version in POM to add support for Java 17
Minor test update to work around minor data change in testing Add GH Action workflow