-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change new line value from /n to <br> so the email is correctly formtted #80
Change new line value from /n to <br> so the email is correctly formtted #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can also update itemization of issues utilizing unordered list
- html tag, which also adds the bullet character. Please see https://www.w3schools.com/tags/tag_li.asp
Also, I might be worth it adding
tag into the
PROJECT_LINE
and LINK_LINE
.Thus would be PROJECT_LINE = "...<br>\n" so it still looks readable in String form.
PROJECT_LINE` you might additionally wrap into tag
@@ -106,7 +106,7 @@ public static String createEmailText(String email, List<Issue> issues) { | |||
projectLinksEntry.getValue().stream() | |||
.map(issue -> LINK_LINE.formatted(issue.getBrowseUri().toString())) | |||
.collect(Collectors.joining())) | |||
.collect(joining("\n")), | |||
.collect(joining("<br>")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.collect(joining("<br>")), | |
.collect(joining("<br>\n")), |
So the string represantation is still human-readable
e0bb6fc
to
2140109
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the suggestion, LGTM
}) | ||
.collect(Collectors.joining("\n")); | ||
|
||
return String.format(EMAIL_BODY, getUsername(email), projectHtml, configFileUrl()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return String.format(EMAIL_BODY, getUsername(email), projectHtml, configFileUrl()); | |
return EMAIL_BODY.formatted(getUsername(email), projectHtml, configFileUrl()); |
2140109
to
5b1db05
Compare
resolves #79