Move jira-issue-lottery.config-file-repo value from application.properties to .env file and set a default for testing. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjusko
force-pushed
the
move-config-url-to-env-file
branch
from
8cfed41 to
5d06ea2
Compare
xstefank
requested changes
Feb 27, 2024
README.md
Outdated
|
|
||
| ### Create .env File | ||
| 1. Create a `.env` file in the main directory of your app. | ||
| 2. Create a Jira Personal Access Token ([Guide on how to create the token](https://confluence.atlassian.com/enterprise/using-personal-access-tokens-1026032365.html)) | ||
| 3. Add the following variable to the `.env` file: | ||
| 2. Add the value of `%dev.jira-issue-lottery.config-file-repo` in the `.env` file to point to a public repository with a valid config file according to first step in [Configuration section](#configure-jira-lottery) such as `https://github.com/jboss-set/jira-issue-lottery`. |
There was a problem hiding this comment.
Why do you need to move it out of application.properties? If it's environment variable than the naming should be adjusted to make it clear - e.g., THIS_IS_ENV_VAR
There was a problem hiding this comment.
The thing is, that in order for the tests to pass we have hardcoded url to this repo (Also for deploying the app itself).
However, if we want to test it upon our own forks of the repository, we would need to override that value all the time in the application.properties. Thus, this way we can have passing test (on local as well) and override the value only for our dev modes, to test new features.
xjusko
force-pushed
the
move-config-url-to-env-file
branch
2 times, most recently
from
f8a55f2 to
d11e28d
Compare
…rties to .env file and set a default for testing.
xjusko
force-pushed
the
move-config-url-to-env-file
branch
from
d11e28d to
b1e9d0e
Compare
xstefank
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #49 as the previous PR which included this was closed