Add LotteryConfig as a parameter to the Executable#execute method, re…

…solves #26
jboss-set · Dec 14, 2023 · d784a33 · d784a33
1 parent c6e5d55
commit d784a33
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/src/main/java/org/jboss/JiraIssueLotteryCommand.java b/src/main/java/org/jboss/JiraIssueLotteryCommand.java
@@ -62,16 +62,17 @@ private JiraConfiguration setupJiraConfiguration() {
     public void run() {
         NewIssueCollector newIssueCollector = NewIssueCollector.getInstance(jiraEndpoint);
         Exchange exchange = jiraEndpoint.createExchange();
+        LotteryConfig lotteryConfig;
         try {
-            LotteryConfig lotteryConfig = objectMapper.readValue(
+            lotteryConfig = objectMapper.readValue(
                     new URI(jiraLotteryAppConfig.configFileRepo().getRawContentsUrl()).toURL(),
                     LotteryConfig.class);
             Log.info(lotteryConfig);
         } catch (IOException | URISyntaxException e) {
             throw new RuntimeException(e);
         }
         try {
-            newIssueCollector.execute().getIssueStates().forEach(Log::info);
+            newIssueCollector.execute(lotteryConfig);
             new IssueProcessor(jiraEndpoint, "JBEAP-25900").process(exchange);
         } catch (Exception e) {
             throw new RuntimeException(e);

diff --git a/src/main/java/org/jboss/processing/Executable.java b/src/main/java/org/jboss/processing/Executable.java
@@ -1,9 +1,11 @@
 package org.jboss.processing;
 
+import org.jboss.config.LotteryConfig;
+
 /**
  * Even if it is basically the same as {@code java.lang.Runnable} interface,
  * due to interference we need a separate interface mimicking it.
  */
-public interface Executable<T> {
-    T execute() throws Exception;
+public interface Executable {
+    void execute(LotteryConfig lotteryConfig) throws Exception;
 }
diff --git a/src/main/java/org/jboss/processing/NewIssueCollector.java b/src/main/java/org/jboss/processing/NewIssueCollector.java
@@ -4,16 +4,16 @@
 import io.quarkus.logging.Log;
 import org.apache.camel.component.jira.JiraEndpoint;
 import org.apache.camel.component.jira.consumer.NewIssuesConsumer;
+import org.jboss.config.LotteryConfig;
 import org.jboss.jql.JqlBuilder;
-import org.jboss.processing.state.EveryIssueState;
 import org.jboss.processing.state.SingleIssueState;
 import org.jboss.query.IssueStatus;
 import org.jboss.query.SearchQuery;
 
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 
-public class NewIssueCollector extends NewIssuesConsumer implements Executable<EveryIssueState> {
+public class NewIssueCollector extends NewIssuesConsumer implements Executable {
 
     private static final State state = new State();
 
@@ -38,9 +38,8 @@ public static NewIssueCollector getInstance(JiraEndpoint jiraEndpoint) {
     }
 
     @Override
-    public EveryIssueState execute() throws Exception {
+    public void execute(LotteryConfig lotteryConfig) throws Exception {
         int issuesCount = doPoll();
         Log.infof("Found number of issues %d", issuesCount);
-        return new EveryIssueState(state.issueStates);
     }
 }
diff --git a/src/main/java/org/jboss/processing/StaleIssueCollector.java b/src/main/java/org/jboss/processing/StaleIssueCollector.java
@@ -4,16 +4,16 @@
 import io.quarkus.logging.Log;
 import org.apache.camel.component.jira.JiraEndpoint;
 import org.apache.camel.component.jira.consumer.NewIssuesConsumer;
+import org.jboss.config.LotteryConfig;
 import org.jboss.jql.JqlBuilder;
-import org.jboss.processing.state.EveryIssueState;
 import org.jboss.processing.state.SingleIssueState;
 import org.jboss.query.IssueStatus;
 import org.jboss.query.SearchQuery;
 
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
 
-public class StaleIssueCollector extends NewIssuesConsumer implements Executable<EveryIssueState> {
+public class StaleIssueCollector extends NewIssuesConsumer implements Executable {
 
     private static final State state = new State();
 
@@ -39,9 +39,8 @@ public static StaleIssueCollector getInstance(JiraEndpoint jiraEndpoint) {
     }
 
     @Override
-    public EveryIssueState execute() throws Exception {
+    public void execute(LotteryConfig lotteryConfig) throws Exception {
         int issuesCount = doPoll();
         Log.infof("Found number of issues %d", issuesCount);
-        return new EveryIssueState(state.issueStates);
     }
 }