Skip to content

Commit

Permalink
Merge pull request #76 from The-Huginn/quarkus-update-fix
Browse files Browse the repository at this point in the history
Update quarkus and remove clutter around fixed quarkus bug
  • Loading branch information
xstefank authored Apr 30, 2024
2 parents b324803 + 7fb9f8d commit 5fb9c07
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 20 deletions.
11 changes: 1 addition & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,8 @@ oc create secret generic jira-lottery
--from-literal=QUARKUS_MAILER_USERNAME={TBD}
--from-literal=QUARKUS_MAILER_PASSWORD={TBD}
```
3. Build the application, this step will eventually fail due to bug in quarkus
3. Build and deploy the application
> **_NOTE:_** You can use script `deploy.sh` for convenience.
```shell
./mvnw clean package -Dquarkus.openshift.deploy=true
```
4. Update CronJob deployment
```shell
cd target/kubernetes
```
And in file `openshift.yml` delete the following line `selector: {}`
5. Deploy the YAML file
```shell
oc apply -f openshift.yml
```
6 changes: 0 additions & 6 deletions deploy.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1 @@
# Tracker issue for quarkus bug. This script serves
# as a workaround for the time being.
# issue: https://github.com/quarkusio/quarkus/issues/38880
# Please delete this script once the fix is released
./mvnw clean package -Dquarkus.kubernetes.deploy=true
sed -i '/^\s*selector: {}/d' target/kubernetes/openshift.yml
oc apply -f target/kubernetes/openshift.yml
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
<quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id>
<quarkus.platform.version>3.5.3</quarkus.platform.version>
<quarkus.platform.version>3.8.3</quarkus.platform.version>
<skipITs>true</skipITs>
<surefire-plugin.version>3.1.2</surefire-plugin.version>
<version.checkstyle>3.3.1</version.checkstyle>
Expand Down
4 changes: 1 addition & 3 deletions src/main/resources/application.properties
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ quarkus.kubernetes.cron-job.schedule=0 0 * * 1
quarkus.openshift.env.secrets=jira-lottery
quarkus.openshift.labels.app=jira-issue-lottery

# These 2 options are disabled to remove labels from selector field. However,
# a manual removal of selector field all together is needed in the generated yml file under target/kubernetes.
# [Tracker] Currently filled issue in quarkus: https://github.com/quarkusio/quarkus/issues/38880
# These 2 options are disabled in order to remove labels from selector field, thus not generating this selector at all. Otherwise, the deployment will fail.
quarkus.openshift.add-version-to-label-selectors=false
quarkus.openshift.add-name-to-label-selectors=false

Expand Down

0 comments on commit 5fb9c07

Please sign in to comment.