Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove image build configurations #544

Draft
wants to merge 1 commit into
base: amqstreams29-dev
Choose a base branch
from
Draft

Remove image build configurations #544

wants to merge 1 commit into from

Conversation

MikeEdgar
Copy link
Collaborator

@MikeEdgar MikeEdgar commented Dec 19, 2024 •
edited
Loading

Remove image build configurations, now managed via the midstream process.

SamBarker
SamBarker approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@SamBarker SamBarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats going to make your GitHub stats look funky for the year: deleting 27kloc

@MikeEdgar
Copy link
Collaborator Author

Thats going to make your GitHub stats look funky for the year: deleting 27kloc

The best code is the code that's deleted 😆

@ppatierno
Copy link
Collaborator

ppatierno commented Dec 20, 2024 •
edited
Loading

If everything is going to be moved in a midstream GitLab, what's the purpose of deleting files here instead of just archiving the repo? Sure I am missing some good reasons for doing this. Is it just for allowing previous builds? But at this point let's just delete the amqstreams29-dev branch because 2.9 will be the first version using GitLab instead of this repo in GitHub?

@MikeEdgar
Copy link
Collaborator Author

If everything is going to be moved in a midstream GitLab, what's the purpose of deleting files here instead of just archiving the repo? Sure I am missing some good reasons for doing this. Is it just for allowing previous builds? But at this point let's just delete the amqstreams29-dev branch because 2.9 will be the first version using GitLab instead of this repo in GitHub?

This repo still has examples and install resources for now.

@ppatierno
Copy link
Collaborator

This repo still has examples and install resources for now.

And why taking these in a separate repo. It would just lead to chaos (something in GitLab, something in GitHub). I would just have everything in GitLab.

@MikeEdgar
Copy link
Collaborator Author

I would just have everything in GitLab.

I don't disagree on that point, but I'd say it's out of scope for this particular PR. I'd argue the examples don't belong in the same place as the build configurations anyway, so we will probably need to discuss how that will look in Gitlab.

@ppatierno
Copy link
Collaborator

I'd argue the examples don't belong in the same place as the build configurations anyway, so we will probably need to discuss how that will look in Gitlab.

Not sure examples would need a dedicated repo. This repo structure was consistent with configuration and examples in one place I don't see it that bad. Said that, we should move everything or nothing imho to avoid making the process more confuse.
I will leave @kyguy @OwenCorrigan76 providing their opinions as well, because they are the ones working on this repo more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamBarker SamBarker SamBarker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeEdgar @ppatierno @SamBarker