Limit the search for posting matches in extreme cases #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With enough potentially-matching postings, the search can take too long to be useful (my CPU was pegged for several minutes before I gave up).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, particularly when there are a couple transactions with many smallish postings (like big Amazon orders), the combinatorial explosion of possible matching sets of transactions becomes intractable to search. These two small changes set limits on both the depth and breadth of searches for matching posting sets, because failing to find the right combination of transactions is preferable to pegging the CPU until beancount-import is forcibly killed.