Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working implementations of StandardSAE and StandardTrainingSAE, along with tests to compare it to old SAE and TrainingSAE implementations. References and folder structure also updated.
Significant change: The old TrainingSAE did not reshape hook_z activations, while the inference SAE did. The former assumed that the ActivationStore would reshape the activations. I suggest we move this functionality to the new training SAEs instead. (Even in cases where caching is used for activations, only ~4% of compute is spent on reshaping--seems worthwhile if it makes the two SAE classes work the same).
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and tests
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)