Fix compiling with Qt 6.8.0 #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Qt developer proposed a similar change in this merge request. Qt version policy says that "Minor releases are backwards binary and source compatible." Either the changed line has used the Qt api in an abusive way or Qt has broken their policy by changing the return type of QAndroidApplication::context() |
jbagg
added a commit
that referenced
this pull request
Jun 28, 2024
QNativeInterface does not provide source compatibility. context() return type changed. https://bugreports.qt.io/browse/QTBUG-123900 Solution contributed by https://github.com/0xFEEDC0DE64 in #68
|
I ended up doing my own commit as I added a comment and fixed a white space issue (tabs vs spaces). I put a note in the commit that it was contributed by this MR . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes my issue #67