avahicore and avahiclient: fixed TXT records update on existing services #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I just noticed that using avahi (avahicore/avahiclient) TXT records of existing services are not getting updated properly...
I mean: if you have an existing service on the network and then update its TXT records somehow QtZeroConf successfully emits the corresponding
serviceUpdated()signal, but theQZeroConfServiceobject passed as parameter still references the previous TXT records (the records before the service update).It's easy to fix that by simply re-processing TXT records before emitting the signal... the same process is already in place for newly-detected services and so it is enough to move the corresponding code block outside the
if(considering the clear them_txtcollection anyway before doing that).