Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ods datetime and time export and import #595

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

pascalfree
Copy link
Contributor

@pascalfree pascalfree commented Jul 10, 2024

The ods format was not matching the spec (Table 14) on datetime and time:

  • datetime must be handled like date: The value goes into the date-value attribute instead of the value attribute.
  • time value must be formatted as a duration according to XML spec.

TODO

  • Add backwards compatibility, to import the broken time format as it is exported in the current version?
  • Add test for time import
  • Add test for datetime export

@claudep
Copy link
Contributor

claudep commented Jul 10, 2024

Thanks! I guess I'll wait for the test before approving? You could also add an entry in HISTORY.md

Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@claudep
Copy link
Contributor

claudep commented Jul 11, 2024

Could you still rebase and squash, please?

HISTORY.md Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
@claudep claudep merged commit d3f6857 into jazzband:master Jul 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants