Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #572 - Allow appending rows after a dynamic column was inserted #573

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Dec 19, 2023

No description provided.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92a7535) 92.41% compared to head (ec9c861) 92.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   92.41%   92.47%   +0.06%     
==========================================
  Files          28       28              
  Lines        2941     2965      +24     
==========================================
+ Hits         2718     2742      +24     
  Misses        223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of small suggestions.

tests/test_tablib.py Show resolved Hide resolved
src/tablib/core.py Outdated Show resolved Hide resolved
src/tablib/core.py Outdated Show resolved Hide resolved
src/tablib/core.py Outdated Show resolved Hide resolved
src/tablib/core.py Outdated Show resolved Hide resolved
@claudep
Copy link
Contributor Author

claudep commented Dec 20, 2023

Thanks for the review, but I'd like to work on it some more, specifically to allow the use case of people inserting complete new rows with dynamic values already calculated, and add some docs about it.

@claudep
Copy link
Contributor Author

claudep commented Dec 20, 2023

A second quick review would be great (also for wording).

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording is fine 👍

@claudep claudep merged commit 01ac5e6 into jazzband:master Dec 21, 2023
21 checks passed
@claudep claudep deleted the issue572 branch December 21, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants