-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape formulae on export #540
Escape formulae on export #540
Conversation
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
+ Coverage 91.15% 91.28% +0.12%
==========================================
Files 28 28
Lines 2680 2719 +39
==========================================
+ Hits 2443 2482 +39
Misses 237 237
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the patch! Could you please also complete the docs in |
Done. To avoid duplication I added links to the source docstrings. Also updated requirements.txt to the latest version of 'Sphinx' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks very good, thanks!
@hugovk, I let you do the merge if you find it OK. |
Thanks! |
Is there a timeline for releasing this? Sorry to ask but we have a downstream security issue relating to this. Any updates greatly appreciated. |
I guess someone has to complete the HISTORY file, but then I think we could release soonish... |
@matthewhegarty If you can make a PR to update |
#544 👍 |
Thank you, now released in 3.4.0! 🚀 |
There is a potential security flaw where XLSX files can be exported with active formulae (see #257).
This PR adds an optional 'escape' kwarg to the export method which will strip leading '=' characters and disable formulae.
Tests included.