Add newline to StringIO #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 90.82% 90.84% +0.01%
==========================================
Files 28 28
Lines 2660 2664 +4
==========================================
+ Hits 2416 2420 +4
Misses 244 244
Continue to review full report at Codecov.
|
|
Thanks! May I ask you to also add a line in |
matthewhegarty
added a commit
to matthewhegarty/tablib
that referenced
this pull request
Feb 21, 2022
matthewhegarty
force-pushed
the
add-newline-to-StringIO-517
branch
from
12aace0
to
6d25fbb
Compare
|
Have updated HISTORY as requested. |
claudep
reviewed
Feb 21, 2022
HISTORY.md
Outdated
|
|
||
| ### Bugfixes | ||
|
|
||
| - Add newline kwarg to `StringIO` (#518). |
There was a problem hiding this comment.
Thanks, but I would rather describe the functional benefit, something like Support solo CR in text input imports.
matthewhegarty
force-pushed
the
add-newline-to-StringIO-517
branch
from
6d25fbb
to
10bd273
Compare
claudep
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #517.
Adding the newline kwarg to
StringIOhandles interpreting the LF char.https://docs.python.org/3/library/functions.html#open-newline-parameter