HTML input: formats.html.import_set #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve the merge conflicts. Thanks 🎉 |
|
I worked on similar functionality, but trying without any external dependency: #555. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
formats.html.import_set imports a Dataset from an HTML table.
It assumes there is exactly one table in the HTML document. (An import_book function would be more appropriate to handle multiple tables, but that doesn't seem very useful.) Headers are taken from elements if they exist.
BeautifulSoup (bs4) is used for HTML parsing, assuming it's OK to add that dependency. I didn't add a copy of bs4 to the "packages" directory since I'm not sure if that is necessary, or why it was done with other dependencies. Alternately, it could be added as a requirement in setup.py. Which way would be best?