👷 Deduplicate cron GHA through workflow reuse #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/gha-reusable-ci-on-cron
branch
2 times, most recently
from
50a0723
to
4528200
Compare
chrysle
approved these changes
Jul 4, 2023
|
It is a bit complex due to the slight differences. Hopefully, we'll rethink those later. I didn't know that cron tested against the pip main branch but there was also another cron in the main workflow that added the usual latest+previous. Plus, it's not really clear why we skip coverage in one of the cron runs. Maybe we could get rid of that conditional as well. That's if someone wants a follow up improvement.. |
This patch melts most of the separate cron workflow into the main CI workflow which it then includes as reusable. Such an approach allows for less duplication of the same CI steps while keeping the cron workflow as a separate entity.
webknjaz
force-pushed
the
maintenance/gha-reusable-ci-on-cron
branch
from
4528200
to
9c87b0e
Compare
|
I think I managed to simplify it a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch melts most of the separate cron workflow into the main CI workflow which it then includes as reusable.
Such an approach allows for less duplication of the same CI steps while keeping the cron workflow as a separate entity.