Skip to content

Commit

Permalink
🎨🔧👷 Wire in linters into the main workflow
Browse files Browse the repository at this point in the history
This patch makes use of reusable workflows to embed the linting jobs
into the main pipeline. The technique allows having modularized CI
definitions stored in separate files but being voting in the
alls-green gate used in branch protection.
  • Loading branch information
webknjaz committed Jul 4, 2023
1 parent 6ae1efc commit 39f6028
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,13 @@ env:
PRE_COMMIT_COLOR
jobs:
linters:
name: Linters
uses: ./.github/workflows/reusable-qa.yml
with:
cpython-pip-version: >-
["main"]
test:
name: ${{ matrix.os }} / ${{ matrix.python-version }} / ${{ matrix.pip-version }}
runs-on: ${{ matrix.os }}-latest
Expand Down Expand Up @@ -143,6 +150,7 @@ jobs:
if: always()

needs:
- linters
- pypy
- test

Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/qa.yml → .github/workflows/reusable-qa.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
name: QA

on:
pull_request:
push:
branches:
- main
tags:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
cancel-in-progress: true
workflow_call:

jobs:
qa:
Expand Down

0 comments on commit 39f6028

Please sign in to comment.