refactor: remove admin monkey patching #513
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: Sites will need to explicitly use TwoFactorAdminSite or
extend the TwoFactorAdminSiteMixin
Motivation and Context
Monkey Patching the AdminSite isn't generally a good practice. We cannot know if users have custom admin sites that we may be breaking or are using other authentication modules that may impact admin login.
Screenshots (if appropriate):
Types of changes
Checklist: