Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove admin monkey patching #513

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Jun 23, 2022

Description

  • remove admin monkey patching.
  • rename admin site classes to use the module namespace.

BREAKING CHANGE: Sites will need to explicitly use TwoFactorAdminSite or
extend the TwoFactorAdminSiteMixin

Motivation and Context

Monkey Patching the AdminSite isn't generally a good practice. We cannot know if users have custom admin sites that we may be breaking or are using other authentication modules that may impact admin login.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dopry dopry force-pushed the remove/monkeypatchedAdmin branch 2 times, most recently from 372465f to 1c27568 Compare June 23, 2022 13:57
- rename admin site classes to use the module namespace.

BREAKING CHANGE: Sites will need to explicitly use TwoFactorAdminSite or
                                      extend the TwoFactorAdminSiteMixin
@dopry dopry force-pushed the remove/monkeypatchedAdmin branch from 1c27568 to ee4d983 Compare June 23, 2022 14:04
@dopry dopry marked this pull request as draft June 23, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant