-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Omit tests directory from code coverage #735
Open
sauravsharma1998
wants to merge
13
commits into
jazzband:master
Choose a base branch
from
sauravsharma1998:fix_code_coverage_tests_dir
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1f5c91f
Fix: Omit tests directory from code coverage
c9fedb3
Add verbose for pytest command
3879b00
Fix: Omit tests directory from code coverage
802223a
Fix: Omit tests directory from pytest via command
f786c50
Fix: Omit tests directory from pytest via command
c015442
Fix: Omit tests directory from coverage
526df6f
Fix: Omit tests directory from mypy
774a8d8
Get code coverage report on the basis of flag management
sauravsharma1998 5bbbfd1
Get code coverage report on the basis of flag management
sauravsharma1998 40c7c2c
codecov.yml removed from project root and updated it in .github
sauravsharma1998 06adbb5
Upload mypy report to smokeshow
sauravsharma1998 ca099d0
Skip mypy report for codecov.io
sauravsharma1998 80b5d84
Fix: Upload mypy report to smokeshow
sauravsharma1998 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| comment: | ||
| layout: "header, diff, flags, components" | ||
|
|
||
| flag_management: | ||
| individual_flags: | ||
| - name: tests | ||
| paths: | ||
| - django_redis/ | ||
| statuses: | ||
| - type: project | ||
|
|
||
| - name: mypy | ||
| paths: | ||
| - django_redis/ | ||
| statuses: | ||
| - type: project |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not change the codecov in
.githubfolder?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WisdomPill Do we require to upload mypy report on coverage.io?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default coverage.io will merge all the coverages, that's why coverage percentage is lower than expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are using codecov, coverage.io does not exist as far as I know. I was asking why did you not change this file instead and created a new one.
And yes we need to upload the coverage of mypy too to codecov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got your point @WisdomPill !
With coverage.io I meant to https://app.codecov.io/
Could you provide any idea, Why mypy coverage is low? It would be helpful to think further in combining both type of reports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MyPy's type checking does not fall under the category of code coverage.
Code coverage typically refers to the measurement of how much of your codebase is exercised by your test suite during execution. It's a metric that indicates the percentage of lines, branches, or other code elements that have been executed by your tests. Code coverage tools like coverage.py or JaCoCo track which parts of your code are executed during testing and generate reports to help you understand how thoroughly your tests exercise your code.
On the other hand, MyPy is a static type checker for Python code. It analyzes your codebase to identify potential type-related issues, inconsistencies, or violations of type hints. MyPy operates statically, meaning it analyzes the code without actually running it. Instead of measuring code coverage, MyPy focuses on ensuring type safety and correctness by enforcing type annotations and performing type inference.
@WisdomPill Please correct me if I am wrong.