-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code_challenge_methods_supported property to OIDC auto discovery #1367
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1367 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 32 32
Lines 2120 2120
=======================================
Hits 2068 2068
Misses 52 52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please "Make sure to request a review by assigning Reviewer jazzband/django-oauth-toolkit" when you are ready for review.
Yes I read this but I think I'm not allowed to. From GitHub docs:
|
57eadbf
to
63ae862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just authorized running the tests and this is failing on tests/test_oidc_views.py:82: AssertionError.
You should be able to see the links to those tests now. Please review and add the necessary changes. Thanks.
I recommend running tox locally to catch these kinds of issues before submitting a PR.
See https://django-oauth-toolkit.readthedocs.io/en/latest/contributing.html#run-the-tests
63ae862
to
3ac4115
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job. Thanks!
Fixes #1249
Description of the Change
Some OIDC clients require code_challenge_methods_supported to be present in auto discovery information. The PR adds this property to ConnectDiscoveryInfoView.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS