Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code_challenge_methods_supported property to OIDC auto discovery #1367

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

gutard
Copy link
Contributor

@gutard gutard commented Nov 13, 2023

Fixes #1249

Description of the Change

Some OIDC clients require code_challenge_methods_supported to be present in auto discovery information. The PR adds this property to ConnectDiscoveryInfoView.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d641f2) 97.54% compared to head (3ac4115) 97.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1367   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          32       32           
  Lines        2120     2120           
=======================================
  Hits         2068     2068           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Show resolved Hide resolved
@gutard
Copy link
Contributor Author

gutard commented Nov 16, 2023

Also please "Make sure to request a review by assigning Reviewer jazzband/django-oauth-toolkit" when you are ready for review.

Yes I read this but I think I'm not allowed to. From GitHub docs:

Note: Pull request authors can't request reviews unless they are either a repository owner or collaborator with write access to the repository.

@gutard gutard force-pushed the code_challenge_methods_supported branch from 57eadbf to 63ae862 Compare November 16, 2023 08:57
@gutard gutard requested a review from n2ygk November 16, 2023 09:00
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just authorized running the tests and this is failing on tests/test_oidc_views.py:82: AssertionError. You should be able to see the links to those tests now. Please review and add the necessary changes. Thanks.

I recommend running tox locally to catch these kinds of issues before submitting a PR.
See https://django-oauth-toolkit.readthedocs.io/en/latest/contributing.html#run-the-tests

@gutard gutard force-pushed the code_challenge_methods_supported branch from 63ae862 to 3ac4115 Compare November 16, 2023 18:47
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Thanks!

@n2ygk n2ygk merged commit a4b26b1 into jazzband:master Nov 16, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code_challenge_methods_supported is not included in the auto discovery information
2 participants