Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AUTHORS alpha sort #1333

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: AUTHORS alpha sort #1333

merged 1 commit into from
Oct 10, 2023

Conversation

dopry
Copy link
Contributor

@dopry dopry commented Oct 5, 2023

  • L with stroke should be treated as L
  • pySilver out of place, do we need a real name here for posterity?

Description of the Change

fix sort in AUTHORS file

Checklist

  • PR only contains one change (considered splitting up PR)
  • [N/A] unit-test added
  • [N/A] documentation updated
  • [N/A] CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1333 (71a50c8) into master (b39ec01) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
+ Coverage   97.39%   97.44%   +0.04%     
==========================================
  Files          32       32              
  Lines        2073     2073              
==========================================
+ Hits         2019     2020       +1     
+ Misses         54       53       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tonial
Copy link
Contributor

tonial commented Oct 10, 2023

I don't think it's an issue if some user stay anonymous.

- L with stroke should be treated as L
- pySilver out of place, do we need a real name here for posterity?
@dopry dopry force-pushed the chore/sort-authors branch from 456bdc3 to 71a50c8 Compare October 10, 2023 15:06
@dopry dopry merged commit 1c4a997 into jazzband:master Oct 10, 2023
26 checks passed
@dopry dopry deleted the chore/sort-authors branch October 10, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants