Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to static tag so STATIC_URL is unneeded #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tisdall
Copy link

@tisdall tisdall commented Sep 2, 2016

STATIC_URL requires adding a context manager while the template
tag requires no specific settings

solution to #175

STATIC_URL requires adding a context manager while the template
tag requires no specific settings
@tisdall
Copy link
Author

tisdall commented Oct 21, 2016

This change also allows people to use CachedStaticFilesStorage and "far future expires" on those files. (I was trying to implement that in my system and wondered why it wasn't working with floppyforms, forgot this hasn't been committed or published yet.)

@cho-leukeleu
Copy link

Hi @gregmuellegger,
Is there something preventing this PR from being merged? :)

@tisdall
Copy link
Author

tisdall commented Feb 14, 2018

@cho-leukeleu - like most open source projects the blocker is probably lack of free time or better things to do. ;)

If this is a change you need it's best to just copy the template into your own project and use that directly. I have this in my code:

class PointWidget(floppyforms.gis.PointWidget, floppyforms.gis.BaseGMapWidget):
    map_width = 560
    template_name = 'google.html'
    google_maps_api_key = settings.GOOGLE_MAP_API_KEY

And then made copies of the templates in the floppyforms/templates/floppforms/gis/ and modified it as needed in my own templates directory.

@cho-leukeleu
Copy link

@tisdall of course, no offense in my question. Simply this change looks quite straight forward to me and there has been another commit since. Now that I look more carefully I guess it's actually because the support for older versions of Django has still not been dropped!
Thanks for the tip.

@tisdall
Copy link
Author

tisdall commented Feb 14, 2018

@cho-leukeleu - This patch seems to pass all the tests which cover older versions of Django, but I haven't really checked if the tests are properly covering things like this. I mentioned I was a little confused how the tests were working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants