Disable logging remote IP address #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Nathan-Cohen for this PR.
|
Nathan-Cohen
force-pushed
the
disable-logging-remote-ip-address
branch
from
e7144ab to
693a509
Compare
|
@hramezani It's done, let me know if I need to make any other changes. |
hramezani
reviewed
Mar 26, 2024
hramezani
reviewed
Mar 26, 2024
hramezani
reviewed
Mar 26, 2024
for more information, see https://pre-commit.ci
hramezani
reviewed
Mar 26, 2024
auditlog_tests/tests.py
Outdated
| @@ -1273,6 +1273,12 @@ def test_register_from_settings_invalid_settings(self): | |||
| ): | |||
| self.test_auditlog.register_from_settings() | |||
|
|
|||
| with override_settings(AUDITLOG_DISABLE_REMOTE_ADDR="str"): | |||
There was a problem hiding this comment.
You need to move this test in MiddlewareTest because the checking is in middleware init
|
Thanks @Nathan-Cohen for the update. Please add a test to showing enabling |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 95.21% 95.24% +0.02%
==========================================
Files 31 31
Lines 1025 1031 +6
==========================================
+ Hits 976 982 +6
Misses 49 49 ☔ View full report in Codecov by Sentry. |
hramezani
approved these changes
Mar 31, 2024
|
Thanks @Nathan-Cohen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've created this Pull Request in response to the user's request regarding the possibility to disable logging of the remote IP address in django-auditlog's audit logs (#524). This feature is desirable in the context of personal data protection, especially in compliance with the General Data Protection Regulation (GDPR).
In this Pull Request, I've added a new configuration, AUDITLOG_DISABLE_REMOTE_ADDR, which allows disabling the logging of the remote IP address. When this configuration is enabled, the remote IP address will no longer be recorded in the audit logs.
I've had to deal with this problem myself and I think it's important to address it for reasons of data confidentiality, which is why I've done this.