Remove apparently obsolete setup.cfg #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 31 31
Lines 1344 1344
=======================================
Hits 1270 1270
Misses 74 74 Continue to review full report at Codecov.
|
|
Please, anyone, review this PR, so we can merge it! |
jezdez
approved these changes
May 2, 2023
|
Thanks Jannis! |
|
@bittner NP, did you see that the CI system isn't working correctly? |
Yes. I just described it in #226 (review). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup.cfgfile contains configuration data that used to be read by tools like Tox and Sphinx.The respective values now appear in pyproject.toml and tox.ini, and it looks like the entire file is hence obsolete.
I'm not 100% sure whether ReadTheDocs reads the file, but I guess building the docs should work just fine without it.