Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printscreen as a special key mapping for 44 #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ifdion
Copy link

@ifdion ifdion commented Oct 16, 2020

Add printscreen as a special key mapping for 44

Add printscreen as a special key mapping  for 44
@coveralls
Copy link

Pull Request Test Coverage Report for Build 796

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.947%

Totals Coverage Status
Change from base Build 731: 0.0%
Covered Lines: 191
Relevant Lines: 211

💛 - Coveralls

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files           1        1           
  Lines         211      211           
=======================================
  Hits          191      191           
  Misses         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ac5c9...e6781e5. Read the comment docs.

@jaywcjlove
Copy link
Owner

jaywcjlove commented Oct 16, 2020

@ifdion It is not a standard key code? macOS keyCode=124, windows keyCode=44, Linux keyCode=42 #217

KeyboardEvent.code Internet Explorer 11 Google Chrome 34 Chromium 34 Safari 7 Gecko 29
Windows Windows Mac (10.9) Linux (Ubuntu 14.04) Mac (10.9) Windows Mac (10.9) Linux (Ubuntu 14.04)
"PrintScreen" 0x2C (44) *4 0x2C (44) *4 0x7C (124)*5 0x2A (42) 0x7C (124)*5 0x2C (44) *4 0x2C (44) 0x2A (42)

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode

@ifdion
Copy link
Author

ifdion commented Oct 19, 2020

@jaywcjlove You're right. Should we check the the value on the user agent as you did on isff?

@jaywcjlove
Copy link
Owner

@ifdion I wonder if there is a better way to achieve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants