Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements and 2 new features #38

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ashikahmad
Copy link

List of improvements:

  • Arrow-images replaced with core-graphics drawing
  • Instead of sunday/monday, startday is customizable to any day
  • New: Tap on month-title brings to Today
  • New: Configuring weekly offday(s)
  • New: can add colored notification-mark on dates from delegates

@jaykz52
Copy link
Owner

jaykz52 commented May 21, 2013

Most of this looks great. Can you give me some background on the "offdays" feature? This feels a little like scope-creep, but maybe I misunderstand it's intention.

With v1, I tried to keep the calendar interface very general, using the delegate methods to allow the developer to make the calendar do what they want it to do, rather than adding additional properties that can be set on the calendar, which cause the calendar to behave/draw somewhat differently (a path this project was starting to go down).

@ashikahmad
Copy link
Author

Thanks, for your quick reply. I love your calendar surely for it's simplicity and readability. What I'm adding is what I feel missing for me at very first look. My intention is make it a bit feature-rich, but without adding extra complexity on implementation, if someone doesn't need them.
Weekly Offdays: Most of the countries have Sunday as weekly offday. But some country (or organizations) use different weekly offday(s) e.g Friday. Showing weekly offday(s) makes it more clear to plan with weekly working days. Currently, default weekly offday is Sunday (but I showed Friday and Saturday in example as they are my official offdays). But if you want this feature lay asleep, you can set default as empty array.
Notification: I've added this last thing, a little coloured triangle at the corner of spacial days as an indication of event or something. It is not to be configured from property, but from the delegate (just with ease!). It seemed valuable adding this to me.
But surely I'm waiting for your response about those features as your approach of keeping simplicity is clearly appreciable. Just I hope, you will find my point of view useful too. Thanks.

@ashikahmad
Copy link
Author

screen shot 2013-05-22 at 12 22 06 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants