If anyone wants some production level code #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added logging fixed sonar issues refactoredcode and removed unwated code updated SQL file for this
|
Great ! , currently no maintainers are active so after reviewing your code i will merge in a week . |
added logging fixed sonar issues refactoredcode and removed unwated code updated SQL file for this
added logging fixed sonar issues refactoredcode and removed unwated code updated SQL file for this
|
Thanks for quick response |
|
it is perfectly running ? if yes then i create another branch for postgresql because it is hard to check all your lots of changes. |
|
Its running fine. Go ahead with new changes
…On Sat, Nov 18, 2023 at 7:19 PM Jay Gajera ***@***.***> wrote:
it is perfectly running ? if yes then i create another branch for
postgresql because it is hard to check all your lots of changes.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI4RL6R4YCV7SYZSAUBW7KTYFC4FTAVCNFSM6AAAAAA6WIO2CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXGUYTINRUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
there is a conflict in pom.xml file and AdminController.java file in master2 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My changes /contributions
developed new logging
added PostgreSQL
fixed sonar issues
removed vulnerabilities
converted script for Postgresql