Added pagination option to include a Previous and Next button #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2018 10:58
…pagination. Default is False.
Removed the e.preventDefault, and changed pagination to use html button tags instead of anchor tags with "#" as the href. As these are not links, a button is a semantically sound approach to handling the pagination and avoids issues of scrolling to the top of the page whenever a page button is clicked.
|
resolve conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will default Previous and Next Buttons to False.
In using the list.js component, we needed an option to include "Prev/Next" buttons in our pagination. Attempting to dynamically add them in our implementation were overwritten by the pagination
refreshfunction where it callspaginationList.clear()