Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore case when getting response headers with prefix #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore case when getting response headers with prefix #171

wants to merge 1 commit into from

Conversation

kjellivar
Copy link

HTTP header names should be case insensitive according to RFC 2616

@igcherkaev
Copy link

Hello. Is it going to get merged? The library doesn't work behind Istio Envoy Proxy.

@kjellivar
Copy link
Author

Just to add: We've been using a forked version with the change in this PR since september 2019 without problem.

@bartlaarhoven bartlaarhoven mentioned this pull request May 21, 2020
Closed
pdowler
pdowler reviewed Jan 17, 2023
View reviewed changes
Copy link

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #188 (now closed) and PR #193 also does this change but includes test code.

I can add that we've been running a fork with this change for a long time as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdowler pdowler pdowler left review comments

@henrik242 henrik242 henrik242 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjellivar @igcherkaev @henrik242 @pdowler