Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #789

wants to merge 1 commit into from

Conversation

neolyte
Copy link

@neolyte neolyte commented Nov 14, 2019

Update the default job types displayed on README.md as they are not representing what they really are anymore and can be confusing.

@neolyte
Update README.md
ce5ae17 
Update the default job types displayed on README.md as they are not representing what they really are anymore and can be confusing.
Base automatically changed from master to main January 20, 2021 18:17
brandondrew
brandondrew suggested changes Mar 5, 2022
View reviewed changes
Copy link

@brandondrew brandondrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to re-order 'runner' and 'script'? It makes the diff less clean.

(I don't have authority to accept your PR here on javan's repo, but I see the merits in your PR, and would like to see it merged. This documentation bug just bit me too.)

@neolyte
Copy link
Author

neolyte commented Mar 8, 2022

Is there any reason to re-order 'runner' and 'script'? It makes the diff less clean.

(I don't have authority to accept your PR here on javan's repo, but I see the merits in your PR, and would like to see it merged. This documentation bug just bit me too.)

I believe (it's been a long time) probably because I simply copied how they are defined in the setup.rb file here

whenever/lib/whenever/setup.rb

Line 27 in e916b58

job_type :command, ":task :output"
That's how they are ordered there

bragamat
bragamat approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@bragamat bragamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benlangfeld let's get it rebased and merged! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandondrew brandondrew brandondrew requested changes

@bragamat bragamat bragamat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neolyte @brandondrew @bragamat