Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme file in order to add docs for Docker usages #770

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,12 @@ This tells rvm to trust all rvmrc files.

No. Heroku does not support cron, instead providing [Heroku Scheduler](https://devcenter.heroku.com/articles/scheduler). If you deploy to Heroku, you should use that rather than Whenever.

### Docker

If you want to use `whenever' in you dockerized rails app, be sure that you have installed `cron` if not add the following line to you `Dockerfile`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to use `whenever' in you dockerized rails app, be sure that you have installed `cron` if not add the following line to you `Dockerfile`
If you want to use `whenever' in you dockerized rails app, be sure that you have installed `cron` on it.


`apt-get install -y cron`

Comment on lines +307 to +309
Copy link
Contributor

@bragamat bragamat Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`apt-get install -y cron`
NOTE: Check your docker image's OS base (e.g. ubuntu, debian, alpine) to know how to properly install it

### Testing

[whenever-test](https://github.com/heartbits/whenever-test) is an extension to Whenever for testing a Whenever schedule.
Expand Down