Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't crash on non-existing roles #539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhomeister
Copy link

When a non-existing role is used for as :whenever_roles, the variable host on line 5 in whenever.rake can be nil.

To reproduce, define :whenever_roles as:

set :whenever_roles, -> { :dummy }

@benlangfeld
Copy link
Collaborator

I'm not sure we really want to silently fail here. We should probably instead raise a more helpful error explaining the issue. Thoughts?

@bragamat
Copy link
Contributor

@rhomeister can you either rebase your PR and address @benlangfeld's comment or close it ?

cc @benlangfeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants