-
Notifications
You must be signed in to change notification settings - Fork 411
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Catch exceptions when writing compiler results (#1015)
Various things may go wrong when a user-provided `Compiler` is producing an `Item`. Typically these end up as a `CompilerError` which gets logged and we stop execution. However, due to laziness, it's possible to have a compiler succeed, but return an `Item` that will throw an exception when it's written. This will break the waiting mechanism in the scheduler, causing a `thread blocked indefinitely in an MVar operation` error like in #1014. I added a test case reproducing this.
- Loading branch information
Showing
2 changed files
with
52 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters