Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

add vhost option #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add vhost option #88

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2018

Hello!

Please add rabbitmq vhost selection. My variant in this request.
If this variant is not good - please tell me why

Copy link
Owner

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good but two changes:

  1. The default for vhost should be '%2f' and not 'root' - have to have URL encoded values.
  2. Since the vhost argument is ONLY used for aliveness, should be named appropriately, e.g.
    aliveness_vhost instead of just vhost

@jasonmcintosh
Copy link
Owner

The command "./scripts/rabbitmq/rabbitmq-status.sh check_aliveness" exited with 1.
Looks like tests are failing on this build. You fixed the api.py but didn't update the script which runs the check (which looks for a blank and sets it). Frankly, could probably remove that default from the shell script but I like keeping it there so people know they can easily override it. Default in the api.py then is probably unnecessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant