CI fix: Use fixed mingw version when building for Windows #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the CI builds for Windows that has been failing for quite some time with the following error message: ``` Cannot find path '... lib\mingw\tools\install\mingw64\x86_64-w64-mingw32\lib\libpthread.dll.a' ``` By upgrading the `egor-tensin/setup-mingw` from version `v2` to `v2.2.0` we are able to specify a specific mingw version. A too new version of mingw, for example 13.2.0, seems to fail the build for us. So let's use the fixed version 12.2.0 which was working fine before. This solution is suggested for example here: egor-tensin/setup-mingw#17 (comment)
|
Note that builds for mingw for platform x86 still fails. But now because of a couple of static asserts instead. They are worth looking into at some point. |
|
thanks much! been struggling for a while now to fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the CI builds for Windows that has been failing for quite some time with the following error message:
By upgrading the
egor-tensin/setup-mingwfrom versionv2tov2.2.0we are able to specify a specific mingw version.A too new version of mingw, for example 13.2.0, seems to fail the build for us. So let's use the fixed version 12.2.0 which was working fine before.
This solution is suggested for example here:
egor-tensin/setup-mingw#17 (comment)