quitcd: fix range limits for new nushell version #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this break for people who have older nushell versions or is the new patch backwards compatible? If it's not backwards compatible, then please document the minimum required version in the comment at the top of the file. |
N-R-K
requested changes
May 27, 2024
No; not in the way it is coded right now. |
|
Resolved with backwards compatibility and fixed trimming issue. |
N-R-K
approved these changes
May 27, 2024
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last version of nushell changed the way ranges work, so the command
str substring 4..-1isn't behaving the way it was anymore.