Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview-tui avoid early exit after SIGWINCH #1747

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Preview-tui avoid early exit after SIGWINCH #1747

merged 1 commit into from
Oct 18, 2023

Conversation

luukvbaal
Copy link
Collaborator

@luukvbaal luukvbaal commented Oct 10, 2023 •
edited
Loading

Fix #1731

@luukvbaal
Copy link
Collaborator Author

luukvbaal commented Oct 10, 2023 •
edited
Loading

Tried fixing this in other ways for a bit but this is the only way that I could find that works. Haven't looked into the reason behind the behavior discrepancy here between POSIX sh and bash 🤷🏻‍♂️

Alternative solutions welcome.

@jarun jarun requested a review from N-R-K October 10, 2023 03:07
N-R-K
N-R-K reviewed Oct 10, 2023
View reviewed changes
plugins/preview-tui Outdated Show resolved Hide resolved
@luukvbaal
Copy link
Collaborator Author

Updated to something that appears to work as well and seems somewhat cleaner.

azuline
azuline approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@azuline azuline left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is working for me! thank you so much!

@jarun jarun merged commit 1051d72 into jarun:master Oct 18, 2023
7 checks passed
@jarun
Copy link
Owner

jarun commented Oct 18, 2023

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@N-R-K N-R-K N-R-K left review comments

@azuline azuline azuline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preview-tui plugin in kitty crashes after second window resize
4 participants
@luukvbaal @jarun @azuline @N-R-K