Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping of paths in editor config #198

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Fix escaping of paths in editor config #198

merged 3 commits into from
Jan 21, 2025

Conversation

jaredpar
Copy link
Owner

This uses / when writing paths to editor config section headers. Windows previously was using \ and that gets treated as a literal escape, not a directory separator.

closes #197

This uses `/` when writing paths to editor config section headers.
Windows previously was using `\` and that gets treated as a literal
escape, not a directory separator.

closes #197
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.04%. Comparing base (b6e3ddd) to head (006ab13).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/Basic.CompilerLog.Util/RoslynUtil.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   97.05%   97.04%   -0.02%     
==========================================
  Files          47       47              
  Lines        4996     5002       +6     
  Branches      511      512       +1     
==========================================
+ Hits         4849     4854       +5     
  Misses         81       81              
- Partials       66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredpar jaredpar merged commit 0fa66d9 into main Jan 21, 2025
3 of 5 checks passed
@jaredpar jaredpar deleted the paths branch January 21, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths in editorconfig sections need to have backslash escaped
1 participant