Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix/types): fix internal & external declaration errors #542

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Mar 6, 2020

  • basically skipLibCheck: false should pass

  • Babel declaration shouldn't have function braces and should have a
    return type

  • enquirer had some typings changes in 2.3.4, seems to be due to
    changes in @types/node

Partially mentioned in #529 (comment), though I found these separately/unintentionally while writing #544

- basically skipLibCheck: false should pass

- Babel declaration shouldn't have function braces and should have a
  return type
- enquirer had some typings changes in 2.3.4, seems to be due to
  changes in @types/node
@agilgur5 agilgur5 merged commit d164dd2 into jaredpalmer:master Mar 9, 2020
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
)

- basically skipLibCheck: false should pass

- Babel declaration shouldn't have function braces and should have a
  return type
- enquirer had some typings changes in 2.3.4, seems to be due to
  changes in @types/node
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant