fix(2172)!: validateOnMount initialize isValid to false until validation performed #3984
Conversation
🦋 Changeset detectedLatest commit: 33818d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
anonkey
changed the title
anonkey
force-pushed
the
fix/validateonmount-initialize-isvalid-to-false
branch
from
affb616 to
33818d3
Compare
anonkey
changed the title
anonkey
changed the title
anonkey
changed the title
| @@ -152,6 +152,7 @@ export function useFormik<Values extends FormikValues = FormikValues>({ | |||
| const initialTouched = React.useRef(props.initialTouched || emptyTouched); | |||
| const initialStatus = React.useRef(props.initialStatus); | |||
| const isMounted = React.useRef<boolean>(false); | |||
| const validated = React.useRef<boolean>(false); | |||
There was a problem hiding this comment.
I think your move to add a ref here is right, but we should be running validation synchronously on mount if validateOnMount is set such that validation has occurred within the first render pass and there is no potential for the boolean to flip either way.
There was a problem hiding this comment.
How should i run validation synchronously since it may be async ?
There was a problem hiding this comment.
@quantizor any hint ? this cause annoying UI issue for me
There was a problem hiding this comment.
Any chance to fix it ? I really need this fix
|
@quantizor can i have some clue on how you think handling sync validation if validate function is async please ? this bug cause ugly troubles in my ui i wish i solve those |
Related to 2172
Maybe it could be extended to use cases without validateOnMount but with validate function or validationSchema ?